Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update database generator and related unit tests #731

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Jan 2, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR refactors the database generator and updates related unit tests.

Which issue(s) this PR fixes:

Fixes #582

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Jan 2, 2024

Pull Request Test Coverage Report for Build 7395618316

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.1%) to 77.265%

Totals Coverage Status
Change from base Build 7337114071: 2.1%
Covered Lines: 8612
Relevant Lines: 11146

💛 - Coveralls

@adohe adohe self-assigned this Jan 4, 2024
@adohe adohe added this to the 0.10.0 milestone Jan 4, 2024
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

@adohe adohe merged commit 9c44776 into KusionStack:main Jan 4, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model: refactor the Database model according to the new design doc
3 participants