Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: secret generator support external secret type #737

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Jan 7, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

secret generator support external secret type

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Jan 7, 2024
@adohe adohe added this to the 0.10.0 milestone Jan 7, 2024
@adohe adohe force-pushed the secret_generator_support_external_secret_type branch 2 times, most recently from 136f09d to 32d55b2 Compare January 7, 2024 14:31
@coveralls
Copy link

coveralls commented Jan 7, 2024

Pull Request Test Coverage Report for Build 7442608695

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 76.906%

Totals Coverage Status
Change from base Build 7418650555: -0.3%
Covered Lines: 8605
Relevant Lines: 11189

💛 - Coveralls

@adohe adohe changed the title Secret generator support external secret type feat: secret generator support external secret type Jan 8, 2024
@adohe adohe force-pushed the secret_generator_support_external_secret_type branch from 32d55b2 to dd87f9d Compare January 8, 2024 02:48
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit f1722d9 into KusionStack:main Jan 8, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
@adohe adohe deleted the secret_generator_support_external_secret_type branch January 8, 2024 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants