Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kusion init support custom params body in JSON string, replace default value in kusion.yaml of specified template #74

Merged
merged 1 commit into from
Jun 20, 2022
Merged

feat: kusion init support custom params body in JSON string, replace default value in kusion.yaml of specified template #74

merged 1 commit into from
Jun 20, 2022

Conversation

howieyuen
Copy link
Collaborator

close: #72

@howieyuen howieyuen requested a review from a team June 15, 2022 03:29
@coveralls
Copy link

coveralls commented Jun 15, 2022 •
edited

Pull Request Test Coverage Report for Build 2526270748

  • 45 of 64 (70.31%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 73.981%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/scaffold/external_templates.go 7 8 87.5%
pkg/scaffold/project.go 1 4 25.0%
pkg/kusionctl/cmd/init/options.go 34 49 69.39%
Files with Coverage Reduction New Missed Lines %
pkg/kusionctl/cmd/init/options.go 1 71.63%
pkg/scaffold/project.go 6 35.29%
Totals Coverage Status
Change from base Build 2515521935: 0.09%
Covered Lines: 3611
Relevant Lines: 4881
💛 - Coveralls

@howieyuen howieyuen force-pushed the custom-params branch 5 times, most recently from 0bc6b73 to 78fb327 Compare June 16, 2022 08:47
@howieyuen howieyuen added this to the v0.5.0 milestone Jun 17, 2022
@howieyuen howieyuen added kind/feature Categorizes issue or PR as related to a new feature cli labels Jun 17, 2022
@howieyuen howieyuen enabled auto-merge (squash) June 17, 2022 06:43
@howieyuen howieyuen force-pushed the custom-params branch 2 times, most recently from c525d84 to c4c00dc Compare June 17, 2022 08:18
@howieyuen howieyuen requested a review from a team June 17, 2022 08:18
chai2010
chai2010 reviewed Jun 17, 2022
View reviewed changes
pkg/scaffold/project.go Outdated Show resolved Hide resolved
elliotxx
elliotxx previously approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen
feat: kusion init support custom params body in JSON string, replace …
5a7f28e 
…default value in kusion.yaml of specified template
chai2010
chai2010 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elliotxx
elliotxx approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 1c2494f into KusionStack:main Jun 20, 2022
@howieyuen howieyuen deleted the custom-params branch June 20, 2022 03:29
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chai2010 chai2010 chai2010 approved these changes

@elliotxx elliotxx elliotxx approved these changes

Assignees

@howieyuen howieyuen

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

kusion init provides a new way to collect template params value with specified CLI flag
4 participants
@howieyuen @coveralls @chai2010 @elliotxx