Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete server side fields in kubernetes runtime #761

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Jan 25, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR deletes server-side fields in Kubernetes runtime for a more precise and clean resource object.

  • Before:
    image

  • After:
    image

Which issue(s) this PR fixes:

Fixes #705

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Jan 25, 2024

Pull Request Test Coverage Report for Build 7649454368

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 77.009%

Totals Coverage Status
Change from base Build 7649249110: 0.03%
Covered Lines: 8769
Relevant Lines: 11387

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit c7002be into KusionStack:main Jan 25, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: ignore managedFields of K8s resources in kusion preview
3 participants