Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no print unused kcl log #770

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@healthjyk
Copy link
Contributor Author

healthjyk commented Jan 29, 2024

fix bug of unexpected git cloning log
image

@coveralls
Copy link

coveralls commented Jan 29, 2024

Pull Request Test Coverage Report for Build 7752871593

  • -1 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.07%) to 76.941%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/build/builders/kcl/kcl_builder.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/build/builders/kcl/kcl_builder.go 1 74.49%
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
Totals Coverage Status
Change from base Build 7725905829: -0.07%
Covered Lines: 8762
Relevant Lines: 11388

💛 - Coveralls

go.mod Outdated Show resolved Hide resolved
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit c16672e into KusionStack:main Feb 2, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
@healthjyk healthjyk deleted the fix-kpm-run branch March 6, 2024 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants