Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add code runner for configuration code execution #803

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Feb 19, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

add code runner to execute configuration code

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Feb 19, 2024
@adohe adohe added this to the v0.11.0 milestone Feb 19, 2024
@coveralls
Copy link

coveralls commented Feb 19, 2024

Pull Request Test Coverage Report for Build 7968250190

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -6 of 28 (78.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 76.947%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/generate/run/run.go 22 28 78.57%
Totals Coverage Status
Change from base Build 7795660400: 0.09%
Covered Lines: 8785
Relevant Lines: 11417

💛 - Coveralls

@adohe adohe changed the title WIP: add code runner for configuration code execution feat: add code runner for configuration code execution Feb 20, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adohe adohe merged commit 29d5701 into KusionStack:main Feb 21, 2024
6 checks passed
@adohe adohe deleted the feat_code_runner branch February 21, 2024 03:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants