Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: app configuration model definition #805

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind refactor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Feb 20, 2024

Pull Request Test Coverage Report for Build 7970150687

Details

  • -27 of 257 (89.49%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 76.833%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/core/v1/workload/workload.go 74 78 94.87%
pkg/apis/core/v1/workload/container/container.go 156 179 87.15%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/cmd/destroy/options.go 7 81.86%
Totals Coverage Status
Change from base Build 7968280233: 0.2%
Covered Lines: 9021
Relevant Lines: 11741

💛 - Coveralls

@SparkYuan SparkYuan merged commit 4930164 into KusionStack:main Feb 21, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants