Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete the never-arriving return non-nil err #816

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

Pull Request Test Coverage Report for Build 8016614905

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 76.91%

Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/options.go 7 81.86%
Totals Coverage Status
Change from base Build 7985663449: 0.006%
Covered Lines: 9070
Relevant Lines: 11793

💛 - Coveralls

@healthjyk healthjyk self-assigned this Feb 23, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 133ede9 into KusionStack:main Feb 23, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@healthjyk healthjyk deleted the fix-workspace-cmd branch March 6, 2024 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants