Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: util/log support log to stderr and add log-to-stderr flag for kusion compile #82

Merged
merged 1 commit into from
Jul 1, 2022
Merged

feat: util/log support log to stderr and add log-to-stderr flag for kusion compile #82

merged 1 commit into from
Jul 1, 2022

Conversation

howieyuen
Copy link
Collaborator

fix: #75

@howieyuen howieyuen requested review from a team June 27, 2022 09:53
@coveralls
Copy link

coveralls commented Jun 27, 2022 •
edited

Coverage Status

Coverage decreased (-0.1%) to 73.329% when pulling ec64064 on howieyuen:silent-log into afdf541 on KusionStack:main.

elliotxx
elliotxx previously approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen changed the title feat: util/log support silence output and add silent-log option for kusion compile feat: util/log support log to stderr and add log-to-stderr flag for kusion compile Jun 28, 2022
elliotxx
elliotxx reviewed Jun 28, 2022
View reviewed changes
pkg/log/log.go Outdated Show resolved Hide resolved
pkg/log/log.go Show resolved Hide resolved
@adohe adohe self-assigned this Jun 30, 2022
@adohe adohe added the cli label Jun 30, 2022
@adohe adohe added this to the v0.5.0 milestone Jun 30, 2022
@adohe
Copy link
Contributor

adohe commented Jun 30, 2022

/lgtm

@howieyuen howieyuen requested a review from elliotxx June 30, 2022 03:44
@elliotxx elliotxx requested review from adohe and a team June 30, 2022 06:33
elliotxx
elliotxx approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit b02b252 into KusionStack:main Jul 1, 2022
@howieyuen howieyuen deleted the silent-log branch July 1, 2022 03:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@markliby markliby markliby approved these changes

@adohe adohe Awaiting requested review from adohe

Assignees

@adohe adohe

Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Concurrent execute kusion compile error
5 participants
@howieyuen @coveralls @adohe @elliotxx @markliby