Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sub cmd of kusion project and stack #826

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Feb 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for sub command of kusion project and kusion stack.

Which issue(s) this PR fixes:

Fixes #782

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8778103431

Details

  • 323 of 365 (88.49%) changed or added relevant lines in 9 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.8%) to 55.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/project/cmd.go 20 22 90.91%
pkg/cmd/stack/cmd.go 20 22 90.91%
pkg/cmd/cmd.go 0 3 0.0%
pkg/cmd/project/create/options.go 38 41 92.68%
pkg/cmd/project/util/util.go 33 37 89.19%
pkg/cmd/stack/create/options.go 58 68 85.29%
pkg/cmd/stack/util/util.go 70 88 79.55%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
Totals Coverage Status
Change from base Build 8771191263: 0.8%
Covered Lines: 8744
Relevant Lines: 15856

💛 - Coveralls

@liu-hm19 liu-hm19 requested a review from adohe February 27, 2024 03:14
@liu-hm19 liu-hm19 self-assigned this Mar 6, 2024
@liu-hm19 liu-hm19 added this to the v0.12.0 milestone Apr 1, 2024
@liu-hm19 liu-hm19 changed the title feat: support create and delete cmd of kusion project and stack feat: support sub cmd of kusion project and stack Apr 16, 2024
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit f29f498 into KusionStack:main Apr 22, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: add command of kusion project and kusion stack
3 participants