Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add generate cmd implementation #843

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Mar 3, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

add generate cmd implementation

Which issue(s) this PR fixes:

Fixes #797

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added area/cli kind/feature Categorizes issue or PR as related to a new feature labels Mar 3, 2024
@adohe adohe added this to the v0.11.0 milestone Mar 3, 2024
@adohe adohe force-pushed the feat_generate_cmd branch 3 times, most recently from c4a9d42 to 4dc3c4e Compare March 20, 2024 00:37
@coveralls
Copy link

coveralls commented Mar 20, 2024

Pull Request Test Coverage Report for Build 8409613638

Details

  • 2 of 205 (0.98%) changed or added relevant lines in 8 files are covered.
  • 143 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-2.1%) to 59.184%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/build/builders/kcl/kcl_builder.go 0 1 0.0%
pkg/oci/client/push.go 0 2 0.0%
pkg/cmd/generate/run/run.go 0 8 0.0%
pkg/util/io/file.go 0 28 0.0%
pkg/cmd/generate/generate.go 0 50 0.0%
pkg/cmd/mod/mod_push.go 0 50 0.0%
pkg/cmd/generate/generator/generator.go 0 64 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/build/builders/kcl/util.go 2 84.0%
pkg/cmd/build/options.go 5 68.29%
pkg/cmd/build/builders/kcl/type.go 9 0.0%
pkg/cmd/generate/run/run.go 21 0.0%
pkg/cmd/build/util.go 31 50.0%
pkg/cmd/build/builders/kcl/kcl_builder.go 75 0.0%
Totals Coverage Status
Change from base Build 8370530303: -2.1%
Covered Lines: 7327
Relevant Lines: 12380

💛 - Coveralls

@adohe adohe force-pushed the feat_generate_cmd branch 2 times, most recently from 1924671 to 782fbeb Compare March 24, 2024 12:26
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 4597780 into KusionStack:main Mar 24, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: rename kusion build to kusion generate
4 participants