Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update api package for enhanced maintainability #871

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Mar 5, 2024

What type of PR is this?

What this PR does / why we need it:

update api package for enhanced maintainability

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added area/cli kind/optimization Code optimization labels Mar 5, 2024
@adohe adohe added this to the v0.11.0 milestone Mar 5, 2024
@adohe adohe changed the title refact: update api package for enhanced maintainability refactor: update api package for enhanced maintainability Mar 9, 2024
@adohe adohe modified the milestones: v0.11.0, v0.12.0 Apr 1, 2024
@adohe adohe force-pushed the refact_api_structure branch 2 times, most recently from 6195b8d to 3b24696 Compare April 5, 2024 11:01
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8568895369

Details

  • 230 of 283 (81.27%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 59.147%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/internal.kusion.io/v1/marshal.go 128 135 94.81%
pkg/apis/internal.kusion.io/v1/unmarshal.go 102 122 83.61%
pkg/apis/api.kusion.io/v1/resource.go 0 26 0.0%
Totals Coverage Status
Change from base Build 8506572024: 0.6%
Covered Lines: 7569
Relevant Lines: 12797

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 40ad5b6 into KusionStack:main Apr 5, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants