Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reorganize states directory #88

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

SparkYuan
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/states

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

reorganize states directory with local state and remote state

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

fix: add yaml tags to Spec
@SparkYuan SparkYuan requested review from a team, adohe, elliotxx and howieyuen July 4, 2022 12:58
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 73.134% when pulling 8944778 on SparkYuan:reorganize_states into b02b252 on KusionStack:main.

@adohe adohe self-assigned this Jul 4, 2022
@adohe adohe added engine kind/optimization Code optimization labels Jul 4, 2022
@adohe adohe added this to the v0.5.0 milestone Jul 4, 2022
@adohe
Copy link
Contributor

adohe commented Jul 4, 2022

/lgtm

Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit f0cc4c4 into KusionStack:main Jul 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2022
@SparkYuan SparkYuan deleted the reorganize_states branch June 26, 2023 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants