Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add kusion config core functions #883

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Feat: add kusion config core functions #883

merged 5 commits into from
Mar 7, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@healthjyk healthjyk requested review from adohe and liu-hm19 March 6, 2024 09:03
@coveralls
Copy link

coveralls commented Mar 6, 2024

Pull Request Test Coverage Report for Build 8169795138

Details

  • 347 of 430 (80.7%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 73.698%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/util.go 31 45 68.89%
pkg/config/operator.go 296 365 81.1%
Totals Coverage Status
Change from base Build 8166754543: 0.3%
Covered Lines: 7386
Relevant Lines: 10022

💛 - Coveralls

@healthjyk healthjyk requested a review from SparkYuan March 6, 2024 09:29
@healthjyk
Copy link
Contributor Author

Please use "Rebase and merge"! @liu-hm19

@healthjyk healthjyk changed the title Feat: Add kusion config core functions Feat: add kusion config core functions Mar 6, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@healthjyk healthjyk merged commit 2f79084 into main Mar 7, 2024
8 checks passed
@healthjyk healthjyk deleted the config branch March 7, 2024 03:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants