Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add backend config completion and validation funcs #891

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat: add backend config completion and validation funcs #891

merged 1 commit into from
Mar 7, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@healthjyk healthjyk self-assigned this Mar 7, 2024
@coveralls
Copy link

coveralls commented Mar 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8184682148

Details

  • 87 of 101 (86.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 73.812%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/backend/storages/completion.go 32 34 94.12%
pkg/backend/storages/validation.go 55 67 82.09%
Totals Coverage Status
Change from base Build 8183879786: 0.1%
Covered Lines: 7472
Relevant Lines: 10123
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@healthjyk healthjyk merged commit d08bf9d into KusionStack:main Mar 7, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

@adohe adohe Awaiting requested review from adohe

Assignees

@healthjyk healthjyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@healthjyk @coveralls @liu-hm19