Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove state model to pkg apis/core/v1 and stateStorage interface to pkg state #897

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@healthjyk healthjyk requested review from adohe and liu-hm19 March 8, 2024 09:42
@coveralls
Copy link

coveralls commented Mar 8, 2024

Pull Request Test Coverage Report for Build 8230708132

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 73.852%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
Totals Coverage Status
Change from base Build 8215284520: -0.03%
Covered Lines: 7541
Relevant Lines: 10211

💛 - Coveralls

@healthjyk healthjyk force-pushed the state-model branch 2 times, most recently from c4615ea to a529b96 Compare March 11, 2024 08:09
@liu-hm19 liu-hm19 changed the title feat: remove state model to pkg apis/core/v1 and stateStorage interfce to pkg state feat: remove state model to pkg apis/core/v1 and stateStorage interface to pkg state Mar 11, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 77bf2d1 into KusionStack:main Mar 11, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants