Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Runtime interface #90

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Conversation

SparkYuan
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/runtime

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

refactor engine/runtime and do not change any features

  • combine Runtime interface request params and result params into Request struct and Response struct to make it easier to iterate in future
  • add dryRun option in Runtime.Apply

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@SparkYuan SparkYuan requested review from a team July 5, 2022 06:41
@coveralls
Copy link

coveralls commented Jul 5, 2022

Coverage Status

Coverage increased (+0.007%) to 72.628% when pulling d8aa884 on SparkYuan:refactor_runtime into b8ba9fc on KusionStack:main.

howieyuen
howieyuen previously approved these changes Jul 5, 2022
@adohe adohe self-assigned this Jul 6, 2022
@adohe adohe added the engine label Jul 6, 2022
pkg/engine/runtime/runtime.go Outdated Show resolved Hide resolved
@howieyuen
Copy link
Collaborator

squash commits into one, try to keep PR mono

@SparkYuan
Copy link
Member Author

This PR will be merged in suqash automatically by github

@SparkYuan SparkYuan added this to the v0.6.0 milestone Jul 6, 2022
@howieyuen
Copy link
Collaborator

This PR will be merged in suqash automatically by github

I have to say, this is really not a good habit.

@howieyuen
Copy link
Collaborator

please reorganize import statements by the way when squashing commits

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, will open other PR to fix import issue.

@adohe adohe merged commit 9ba14e2 into KusionStack:main Jul 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
@SparkYuan SparkYuan deleted the refactor_runtime branch June 26, 2023 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants