Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused backend config in workspace #921

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@healthjyk healthjyk requested review from adohe, SparkYuan and liu-hm19 and removed request for adohe March 14, 2024 08:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8277776857

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.4%) to 72.84%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/workspace/util.go 1 79.82%
pkg/workspace/validation.go 1 83.52%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/engine/operation/parser/parser.go 6 75.61%
Totals Coverage Status
Change from base Build 8275253521: 0.4%
Covered Lines: 7209
Relevant Lines: 9897

💛 - Coveralls

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe merged commit ad86ddd into KusionStack:main Mar 17, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants