Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepend patch env to existing env slices so developers can reference them later on #922

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

SparkYuan
Copy link
Member

…rence them later on.

What type of PR is this?

/kind feature

What this PR does / why we need it:

prepend patch env to existing env slices so developers can reference them later on.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Mar 14, 2024

Pull Request Test Coverage Report for Build 8277927170

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 72.439%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/plugin.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 8275253521: 0.02%
Covered Lines: 7275
Relevant Lines: 10043

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 1466e5a into KusionStack:main Mar 14, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants