Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump go version to 1.22 #934

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Mar 18, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR bumps the go version from 1.19 to 1.22 and fix some lint errors.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Mar 18, 2024

Pull Request Test Coverage Report for Build 8323429566

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-8.9%) to 62.61%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/destroy/options.go 7 82.55%
Totals Coverage Status
Change from base Build 8321681199: -8.9%
Covered Lines: 7378
Relevant Lines: 11784

💛 - Coveralls

@SparkYuan
Copy link
Member

@liu-hm19 The test coverage has significantly decreased. Please fix the test coverage before merging this PR

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe self-assigned this Mar 18, 2024
@adohe adohe merged commit 8ce6cfa into KusionStack:main Mar 18, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants