Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refator: unify diff util functions, remove dup implements #94

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Jul 12, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N

2. What is the scope of this PR (e.g. component or file name):

pkg/util/diff/diff.go
pkg/engine/operation/diff.go
pkg/kusionctl/cmd/diff/options.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • refactor diff util implements

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

refatcor pkg/util/diff, support `ToHumanReportString`, `ToRawReportString` and `ToReportString` for both

@howieyuen howieyuen requested review from a team July 12, 2022 08:00
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 73.071% when pulling 40306cf on howieyuen:refactor-diff-util into 182d162 on KusionStack:main.

@howieyuen howieyuen changed the title refator: unify diff util functions, delete similar code refator: unify diff util functions, remove dup implementions Jul 14, 2022
@howieyuen howieyuen changed the title refator: unify diff util functions, remove dup implementions refator: unify diff util functions, remove dup implements Jul 14, 2022
@howieyuen howieyuen added the kind/optimization Code optimization label Jul 14, 2022
@howieyuen howieyuen added this to the v0.6.0 milestone Jul 14, 2022
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

@howieyuen howieyuen merged commit 13781ca into KusionStack:main Jul 19, 2022
@howieyuen howieyuen deleted the refactor-diff-util branch July 19, 2022 03:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants