Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor the old usage of workspace and backend #944

Merged
merged 1 commit into from
Mar 19, 2024
Merged

feat: refactor the old usage of workspace and backend #944

merged 1 commit into from
Mar 19, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8339532743

Details

  • 92 of 113 (81.42%) changed or added relevant lines in 9 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 60.828%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/build/options.go 9 11 81.82%
pkg/cmd/build/util.go 4 6 66.67%
pkg/cmd/destroy/options.go 22 27 81.48%
pkg/cmd/apply/options.go 25 31 80.65%
pkg/cmd/preview/options.go 23 29 79.31%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/build/options.go 2 67.78%
pkg/cmd/destroy/options.go 7 81.11%
Totals Coverage Status
Change from base Build 8338915967: -0.1%
Covered Lines: 7376
Relevant Lines: 12126
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@healthjyk healthjyk merged commit 7e434b3 into KusionStack:main Mar 19, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@healthjyk @coveralls @liu-hm19