Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npe when killing plugin client #947

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 8343595030

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 60.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/plugin.go 0 5 0.0%
Totals Coverage Status
Change from base Build 8343405451: -0.01%
Covered Lines: 7463
Relevant Lines: 12315

💛 - Coveralls

pkg/modules/plugin.go Outdated Show resolved Hide resolved
@healthjyk
Copy link
Contributor

Besides, plz make the title clearer.

@SparkYuan SparkYuan changed the title fix: plugin npe fix: npe when killing plugin client Mar 19, 2024
@SparkYuan SparkYuan enabled auto-merge (squash) March 19, 2024 13:13
@SparkYuan SparkYuan merged commit 047a563 into KusionStack:main Mar 19, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants