Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse field Cluster From Resource.Extensions in CLI #95

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

SparkYuan
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/kusionctl/cmd/apply
pkg/engine/states/local/

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
  1. Parse field Cluster From Resource.Extensions in CLI
  2. Rollback yaml.v3 to v2 for a known bug in v3

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

2. rollback yaml.v3 to v2 for a known bug in v3
@SparkYuan SparkYuan requested review from a team July 13, 2022 06:38
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 72.622% when pulling 55f8a30 on SparkYuan:add_cluster_in_cli into 182d162 on KusionStack:main.

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

@SparkYuan SparkYuan merged commit c01d453 into KusionStack:main Jul 13, 2022
@SparkYuan SparkYuan deleted the add_cluster_in_cli branch July 13, 2022 07:01
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants