Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spec storage and integrate with generate cmd #953

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Mar 24, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

add spec storage implementation

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Mar 24, 2024
@adohe adohe added this to the v0.11.0 milestone Mar 24, 2024
@coveralls
Copy link

coveralls commented Mar 24, 2024

Pull Request Test Coverage Report for Build 8414854393

Details

  • 0 of 178 (0.0%) changed or added relevant lines in 11 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 58.448%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/generate/generator/generator.go 0 2 0.0%
pkg/backend/storages/local.go 0 3 0.0%
pkg/backend/storages/mysql.go 0 3 0.0%
pkg/backend/storages/oss.go 0 3 0.0%
pkg/backend/storages/s3.go 0 3 0.0%
pkg/backend/backend.go 0 6 0.0%
pkg/engine/spec/storages/util.go 0 9 0.0%
pkg/engine/spec/storages/local.go 0 28 0.0%
pkg/cmd/generate/generate.go 0 32 0.0%
pkg/engine/spec/storages/oss.go 0 41 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/generate/generate.go 1 0.0%
pkg/cmd/generate/generator/generator.go 1 0.0%
Totals Coverage Status
Change from base Build 8414798303: -0.6%
Covered Lines: 7327
Relevant Lines: 12536

💛 - Coveralls

@adohe adohe changed the title feat: add spec storage feat: add spec storage and integrate with generator cmd Mar 25, 2024
@liu-hm19 liu-hm19 changed the title feat: add spec storage and integrate with generator cmd feat: add spec storage and integrate with generate cmd Mar 25, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 99cca76 into KusionStack:main Mar 25, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
@adohe adohe deleted the feat_spec_storage branch April 1, 2024 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants