Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to init cmd to specify output file path #954

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

skoenig
Copy link
Contributor

@skoenig skoenig commented Mar 24, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #344

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., design docs, usage docs, etc.:


Copy link

github-actions bot commented Mar 24, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@skoenig
Copy link
Contributor Author

skoenig commented Mar 24, 2024

I have read the CLA Document and I hereby sign the CLA

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8411517684

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 17 (88.24%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 59.18%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/init/options.go 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 8409888263: 0.1%
Covered Lines: 7333
Relevant Lines: 12391

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 1a731f6 into KusionStack:main Mar 27, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: kusion init support --target(-t) option to set the target path to output the generated files
3 participants