Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update yaml package for appconfiguration generator #956

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This updates the use of the yaml package in app_configurations_generator, unmarshaling Workload with yaml.v2 and unmarshaling other generator request attributes with yaml.v3.

Which issue(s) this PR fixes:

Fixes #940

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 requested a review from SparkYuan March 25, 2024 08:27
@liu-hm19 liu-hm19 self-assigned this Mar 25, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8417152786

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 58.392%

Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/options.go 7 71.04%
Totals Coverage Status
Change from base Build 8415808851: -0.06%
Covered Lines: 7320
Relevant Lines: 12536

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit c7a17ae into KusionStack:main Mar 25, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: using yaml.v2 for deserialization may lead to failure in json serialization
3 participants