Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse dev config mod's namespace and version form kcl.mod #959

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan force-pushed the parse-kpm-version branch 5 times, most recently from 7885bbd to 9bc41df Compare March 25, 2024 13:20
@coveralls
Copy link

coveralls commented Mar 25, 2024

Pull Request Test Coverage Report for Build 8420948750

Details

  • 67 of 139 (48.2%) changed or added relevant lines in 14 files are covered.
  • 18 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 58.134%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/build/util.go 0 1 0.0%
pkg/cmd/generate/generator/generator.go 0 1 0.0%
pkg/modules/plugin.go 0 1 0.0%
pkg/cmd/build/builders/appconfig_builder.go 4 6 66.67%
pkg/apis/core/v1/workload/container/container.go 20 23 86.96%
pkg/cmd/build/builders/kcl/kcl_builder.go 0 5 0.0%
pkg/cmd/generate/generate.go 0 5 0.0%
pkg/cmd/build/options.go 0 8 0.0%
pkg/cmd/generate/run/run.go 0 13 0.0%
pkg/modules/generators/app_configurations_generator.go 29 62 46.77%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/build/options.go 1 63.64%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/engine/operation/parser/parser.go 6 75.61%
pkg/cmd/apply/options.go 7 71.15%
Totals Coverage Status
Change from base Build 8417449246: -0.3%
Covered Lines: 7333
Relevant Lines: 12614

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 0eb0494 into KusionStack:main Mar 26, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants