-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support deleted files in kusion deps cmd #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyXia1994
force-pushed
the
dev/xiarui.xr/deps-support-deleted
branch
from
July 15, 2022 08:34
57c6bfa
to
06d049c
Compare
elliotxx
reviewed
Jul 18, 2022
elliotxx
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
howieyuen
approved these changes
Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
before the PR, the in-existing file paths as
--focus
option is not allowed in using thekusion deps
command to find downstream stacks/projects and the in-existing file paths will cause an "invalid focus path" error.This PR support deleted files in
kusion deps --focus
option, and slightly improves the performance of that command.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
This PR adds some unit tests and benchmarks on the core logic about down stream stacks/projects analyzing.
This PR brings some reduction on memory usage result based on the testdata and brings about 50% time and memory consumption base on a 2000+ stacks Konfig repository.
benchstat result on processing downstream stacks/projects of the testdata:
benchstat result on procession a 2000+ stacks Konfig repository:
6. Release note