Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mod push add examples dir also mark generator executable #964

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Mar 26, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

mod push add example dir also mark generator executable

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Mar 26, 2024
@adohe adohe added this to the v0.11.0 milestone Mar 26, 2024
@coveralls
Copy link

coveralls commented Mar 26, 2024

Pull Request Test Coverage Report for Build 8433109945

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 79 (0.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 58.109%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/mod/mod_push.go 0 3 0.0%
pkg/cmd/generate/generator/generator.go 0 4 0.0%
pkg/util/io/file.go 0 17 0.0%
pkg/util/io/dir.go 0 55 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/generate/generator/generator.go 2 0.0%
Totals Coverage Status
Change from base Build 8432448062: -0.2%
Covered Lines: 7356
Relevant Lines: 12659

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 7642064 into KusionStack:main Mar 26, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants