Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: use client side dry-run to be compatible with server side dry-run not support #97

Merged
merged 1 commit into from
Jul 14, 2022
Merged

bugfix: use client side dry-run to be compatible with server side dry-run not support #97

merged 1 commit into from
Jul 14, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Jul 14, 2022 •
edited

close: #98

@howieyuen howieyuen requested a review from a team July 14, 2022 09:00
@howieyuen howieyuen added this to the v0.6.0 milestone Jul 14, 2022
@howieyuen howieyuen added kind/bug Something isn't working and removed kind/bug Something isn't working labels Jul 14, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 72.622% when pulling 3936b8b on howieyuen:fix-dry-run-not-support into c01d453 on KusionStack:main.

@SparkYuan SparkYuan merged commit 6d8d86f into KusionStack:main Jul 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@adohe adohe adohe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

kusion apply failed, return "dry run not support"
4 participants
@howieyuen @coveralls @SparkYuan @adohe