Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: yaml.v2 unmarshal json content, make metadata type map[interface{}]interface{} #99

Merged
merged 1 commit into from
Jul 18, 2022
Merged

bugfix: yaml.v2 unmarshal json content, make metadata type map[interface{}]interface{} #99

merged 1 commit into from
Jul 18, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Jul 14, 2022 •
edited

  • use gopkg.in/yaml.v3 instead of gopkg.in/yaml.v2, and change the db_stage by the way
  • runtime dry-run not cover create verb, add it

@howieyuen howieyuen requested a review from a team July 14, 2022 13:22
@coveralls
Copy link

coveralls commented Jul 14, 2022 •
edited

Coverage Status

Coverage increased (+0.04%) to 72.622% when pulling 3b06967 on howieyuen:fix-json-marshal into 6d8d86f on KusionStack:main.

@howieyuen howieyuen force-pushed the fix-json-marshal branch 2 times, most recently from e8611ec to dad1c2c Compare July 14, 2022 15:41
@howieyuen howieyuen changed the title bugfix: json.marshal not supported type: map[interface{}]interface{} bugfix: filesystem_state use gopkg.in/yaml.v2 to unmarshal json content, make metadata type map[interface{}]interface{} Jul 14, 2022
@howieyuen howieyuen changed the title bugfix: filesystem_state use gopkg.in/yaml.v2 to unmarshal json content, make metadata type map[interface{}]interface{} bugfix: yaml.v2 unmarshal json content, make metadata type map[interface{}]interface{} Jul 14, 2022
@howieyuen howieyuen added this to the v0.6.0 milestone Jul 15, 2022
@howieyuen howieyuen linked an issue Jul 15, 2022 that may be closed by this pull request
kusion apply failed, return "dry run not support" #98
Closed
@howieyuen howieyuen requested a review from a team July 15, 2022 08:51
@howieyuen
bugfix: filesystem_state use gopkg.in/yaml.v2 to unmarshal json conte…
3b06967 
…nt, make metadata type map[interface{}]interface{}
adohe
adohe approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

@SparkYuan SparkYuan merged commit 5dc798c into KusionStack:main Jul 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2022
@howieyuen howieyuen deleted the fix-json-marshal branch December 15, 2022 06:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@adohe adohe adohe approved these changes

Assignees

@SparkYuan SparkYuan

@adohe adohe

Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

kusion apply failed, return "dry run not support"
4 participants
@howieyuen @coveralls @SparkYuan @adohe