optimize: make alibaba_cloud_slb controller optional (#80)

* optimize: make alibaba_cloud_slb controller optional
KusionStack · Aug 31, 2023 · 8a081ee · 8a081ee
1 parent 55052b3
commit 8a081ee
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/pkg/controllers/add_alibaba_cloud_slb.go b/pkg/controllers/add_alibaba_cloud_slb.go
@@ -21,13 +21,18 @@ import (
 
 	"kusionstack.io/kafed/pkg/controllers/alibaba_cloud_slb"
 	"kusionstack.io/kafed/pkg/controllers/resourceconsist"
+	"kusionstack.io/kafed/pkg/features"
+	"kusionstack.io/kafed/pkg/utils/feature"
 )
 
 func init() {
 	AddToManagerFuncs = append(AddToManagerFuncs, Add)
 }
 
 func Add(manager manager.Manager) error {
+	if !feature.DefaultFeatureGate.Enabled(features.AlibabaCloudSlb) {
+		return nil
+	}
 	reconcileAdapter, err := alibaba_cloud_slb.NewReconcileAdapter(manager.GetClient())
 	if err != nil {
 		return err

diff --git a/pkg/controllers/add_podopslifecycle.go b/pkg/controllers/add_podopslifecycle.go
@@ -18,12 +18,8 @@ package controllers
 
 import (
 	"kusionstack.io/kafed/pkg/controllers/podopslifecycle"
-	"kusionstack.io/kafed/pkg/features"
-	"kusionstack.io/kafed/pkg/utils/feature"
 )
 
 func init() {
-	if feature.DefaultFeatureGate.Enabled(features.PodOpsLifecycle) {
-		AddToManagerFuncs = append(AddToManagerFuncs, podopslifecycle.Add)
-	}
+	AddToManagerFuncs = append(AddToManagerFuncs, podopslifecycle.Add)
 }
diff --git a/pkg/features/features.go b/pkg/features/features.go
@@ -24,12 +24,12 @@ import (
 )
 
 const (
-	// PodOpsLifecycle enables the PodOpsLifecycle controller.
-	PodOpsLifecycle featuregate.Feature = "PodOpsLifecycle"
+	// AlibabaCloudSlb enables the alibaba_cloud_slb controller.
+	AlibabaCloudSlb featuregate.Feature = "AlibabaCloudSlb"
 )
 
 var defaultFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{
-	PodOpsLifecycle: {Default: true, PreRelease: featuregate.Alpha},
+	AlibabaCloudSlb: {Default: false, PreRelease: featuregate.Alpha},
 }
 
 func init() {