Skip to content

Commit

Permalink
enhancement (CollaSet): fix review issues
Browse files Browse the repository at this point in the history
  • Loading branch information
wu8685 committed Aug 11, 2023
1 parent 5982630 commit aecafdb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions apis/apps/v1alpha1/collaset_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ type CollaSetStatus struct {
// Replicas is the most recently observed number of replicas.
Replicas int32 `json:"replicas,omitempty"`

// The number of pods in current version.
// The number of pods in updated version.
UpdatedReplicas int32 `json:"updatedReplicas,omitempty"`

// OperatingReplicas indicates the number of pods during pod ops lifecycle and not finish update-phase.
Expand Down Expand Up @@ -256,7 +256,7 @@ type CollaSetCondition struct {
// +kubebuilder:printcolumn:name="CURRENT_REVISION",type="string",JSONPath=".status.currentRevision",description="The current revision."
// +kubebuilder:printcolumn:name="UPDATED_REVISION",type="string",JSONPath=".status.updatedRevision",description="The updated revision."
// +kubebuilder:printcolumn:name="AGE",type="date",JSONPath=".metadata.creationTimestamp"
// +resource:path=collasets,strategy=CollaSetStrategy
// +resource:path=collasets
type CollaSet struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/apps.kafed.io_collasets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ spec:
format: int32
type: integer
updatedReplicas:
description: The number of pods in current version.
description: The number of pods in updated version.
format: int32
type: integer
updatedRevision:
Expand Down

0 comments on commit aecafdb

Please sign in to comment.