fix, ruleset webhook validating (#49)

KusionStack · Aug 22, 2023 · bc4476b · bc4476b
1 parent 93d00d0
commit bc4476b
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pkg/webhook/server/generic/pod/ruleset/validating.go b/pkg/webhook/server/generic/pod/ruleset/validating.go
@@ -36,10 +36,13 @@ func (r *RuleSetWebhook) Validating(ctx context.Context, c client.Client, oldPod
 	if !utils.ControlledByPodOpsLifecycle(newPod) || newPod.Annotations == nil {
 		return nil
 	}
-	ruleSetAnno := newPod.Annotations[appsv1alpha1.AnnotationRuleSets]
-	if operation == admissionv1.Update && ruleSetAnno == oldPod.Annotations[appsv1alpha1.AnnotationRuleSets] {
+
+	ruleSetAnno, ok := newPod.Annotations[appsv1alpha1.AnnotationRuleSets]
+	if (operation == admissionv1.Create && !ok) ||
+		(operation == admissionv1.Update && ruleSetAnno == oldPod.Annotations[appsv1alpha1.AnnotationRuleSets]) {
 		return nil
 	}
+
 	rs := &RuleSets{}
 	if err := json.Unmarshal([]byte(ruleSetAnno), rs); err != nil {
 		return fmt.Errorf("fail to unmarshal RuleSet annotation %s: %v", ruleSetAnno, err)