Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add some tests #121

Merged
merged 1 commit into from
Nov 20, 2023
Merged

test: add some tests #121

merged 1 commit into from
Nov 20, 2023

Conversation

wu8685
Copy link
Collaborator

@wu8685 wu8685 commented Nov 19, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (412b4f2) 46.17% compared to head (a3411f9) 59.67%.

Files Patch % Lines
pkg/controllers/collaset/collaset_controller.go 50.00% 0 Missing and 1 partial ⚠️
...lers/podopslifecycle/podopslifecycle_controller.go 50.00% 1 Missing ⚠️
...rver/generic/collaset/collaset_mutating_handler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #121       +/-   ##
===========================================
+ Coverage   46.17%   59.67%   +13.49%     
===========================================
  Files          45       46        +1     
  Lines        3558     3489       -69     
===========================================
+ Hits         1643     2082      +439     
+ Misses       1700     1188      -512     
- Partials      215      219        +4     
Flag Coverage Δ
unittests 59.67% <81.25%> (+13.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaofan-hs shaofan-hs merged commit b976c90 into KusionStack:main Nov 20, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants