Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: PodTransitionRule webhook rule refactor #131

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Dec 8, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references:

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/webhook/server/generic/podtransitionrule

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Eikykun Eikykun self-assigned this Dec 11, 2023
@Eikykun Eikykun added the kind/enhancement New feature or request label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (b976c90) 59.38% compared to head (95746e1) 60.76%.
Report is 1 commits behind head on main.

Files Patch % Lines
...llers/podtransitionrule/processor/rules/webhook.go 78.31% 32 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   59.38%   60.76%   +1.38%     
==========================================
  Files          46       46              
  Lines        3489     3566      +77     
==========================================
+ Hits         2072     2167      +95     
+ Misses       1196     1184      -12     
+ Partials      221      215       -6     
Flag Coverage Δ
unittests 60.76% <81.63%> (+1.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 6568dac into KusionStack:main Dec 12, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants