Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: podTransitionRule webhook #132

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Dec 13, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/controllers/podtransitionrule/processor/rules/webhook.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (6568dac) 60.65% compared to head (b3e3293) 60.90%.

Files Patch % Lines
...llers/podtransitionrule/processor/rules/webhook.go 69.23% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   60.65%   60.90%   +0.24%     
==========================================
  Files          46       46              
  Lines        3566     3573       +7     
==========================================
+ Hits         2163     2176      +13     
+ Misses       1187     1185       -2     
+ Partials      216      212       -4     
Flag Coverage Δ
unittests 60.90% <69.23%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikykun Eikykun requested a review from wu8685 December 15, 2023 02:58
@Eikykun Eikykun self-assigned this Dec 15, 2023
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 3afbc70 into KusionStack:main Dec 15, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants