Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and upgrade podTransitionRule webhook #133

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Dec 15, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references :

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

PodTransitionRule

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • update PodTransitionRule api: remove ItemStatus and expressed it as TaskInfo's Processing/Approved
  • update PodTransitionRule shortName: rs->ptr
  • add PollingManager:
    -> to process webhook polling task alone
    -> trigger PodTransitionRule reconciliation by GenericEvent
  • add some test case in PodTransitionRule

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (3afbc70) 60.81% compared to head (3ae4516) 62.33%.

Files Patch % Lines
...llers/podtransitionrule/processor/rules/webhook.go 75.00% 44 Missing and 7 partials ⚠️
...llers/podtransitionrule/processor/rules/polling.go 75.67% 29 Missing and 7 partials ⚠️
.../podtransitionrule/podtransitionrule_controller.go 66.66% 2 Missing and 1 partial ⚠️
...ers/podtransitionrule/processor/rules/available.go 0.00% 2 Missing ⚠️
...rollers/podtransitionrule/processor/rules/types.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   60.81%   62.33%   +1.51%     
==========================================
  Files          46       47       +1     
  Lines        3573     3672      +99     
==========================================
+ Hits         2173     2289     +116     
+ Misses       1188     1162      -26     
- Partials      212      221       +9     
Flag Coverage Δ
unittests 62.33% <74.86%> (+1.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikykun Eikykun self-assigned this Dec 25, 2023
@Eikykun Eikykun added kind/bug Something isn't working kind/enhancement New feature or request labels Dec 25, 2023
@Eikykun Eikykun requested a review from wu8685 December 26, 2023 03:45
@Eikykun Eikykun changed the title fix podTransitionRule webhook interval and rename PodTransitionRule s… fix and upgrade podTransitionRule webhook Dec 26, 2023
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 4181742 into KusionStack:main Dec 28, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants