Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize ut in podopslifecycle controller #136

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

shaofan-hs
Copy link
Collaborator

@shaofan-hs shaofan-hs commented Dec 22, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references :

  • N
  • Y

re #137

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3afbc70) 60.81% compared to head (c605fb3) 62.02%.

Files Patch % Lines
...lers/podopslifecycle/podopslifecycle_controller.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   60.81%   62.02%   +1.20%     
==========================================
  Files          46       46              
  Lines        3573     3573              
==========================================
+ Hits         2173     2216      +43     
+ Misses       1188     1140      -48     
- Partials      212      217       +5     
Flag Coverage Δ
unittests 62.02% <66.66%> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaofan-hs shaofan-hs force-pushed the podopslifecycle-test branch 3 times, most recently from 744dd5a to 65f9307 Compare December 26, 2023 08:01
Copy link
Member

@Eikykun Eikykun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shaofan-hs shaofan-hs merged commit a302b54 into KusionStack:main Dec 26, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants