-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]Replace update #147
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 63.83% 63.99% +0.16%
==========================================
Files 72 72
Lines 4731 4736 +5
==========================================
+ Hits 3020 3031 +11
+ Misses 1426 1422 -4
+ Partials 285 283 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I have read the CLA Document and I hereby sign the CLA |
02f9d00
to
83ddd82
Compare
d77f77d
to
56fd06e
Compare
1. use replace new id instead of new pod name 2. allocate id when replaceUpdate needed. 3. judge whether pod need update based on whether it is in the "replace" state.
…he process of creating pod and delete pod in replace update and specify pod replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
#111
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.