Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]Replace update #147

Merged
merged 15 commits into from
Mar 11, 2024
Merged

[feature]Replace update #147

merged 15 commits into from
Mar 11, 2024

Conversation

dbug-dk
Copy link
Collaborator

@dbug-dk dbug-dk commented Jan 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

#111

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

github-actions bot commented Jan 12, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.99%. Comparing base (d146ad4) to head (7c1ec1e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   63.83%   63.99%   +0.16%     
==========================================
  Files          72       72              
  Lines        4731     4736       +5     
==========================================
+ Hits         3020     3031      +11     
+ Misses       1426     1422       -4     
+ Partials      285      283       -2     
Flag Coverage Δ
unittests 63.99% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbug-dk
Copy link
Collaborator Author

dbug-dk commented Jan 12, 2024

I have read the CLA Document and I hereby sign the CLA

@dbug-dk dbug-dk force-pushed the replaceUpdate branch 3 times, most recently from 02f9d00 to 83ddd82 Compare January 12, 2024 06:25
1. use replace new id instead of new pod name
2. allocate id when replaceUpdate needed.
3. judge whether pod need update based on whether it is in the "replace" state.
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 5eae342 into KusionStack:main Mar 11, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
@Eikykun Eikykun linked an issue Mar 18, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力 Enhancement: CollaSet supports maxSurge feature when upgrading
2 participants