Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat, init podopslifecycle #16

Merged
merged 4 commits into from
Aug 8, 2023
Merged

feat, init podopslifecycle #16

merged 4 commits into from
Aug 8, 2023

Conversation

shaofan-hs
Copy link
Collaborator

@shaofan-hs shaofan-hs commented Aug 3, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #11

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@KusionStack KusionStack deleted a comment from github-actions bot Aug 3, 2023
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/webhook/server/generic/pod/opslifecycle/webhook.go Outdated Show resolved Hide resolved
pkg/webhook/server/generic/pod/opslifecycle/webhook.go Outdated Show resolved Hide resolved
@wu8685
Copy link
Collaborator

wu8685 commented Aug 5, 2023

There also need to be a ReadinessGate injection and service available condition.

By the way, is it necessary to add a shortcut policy in webhook before going into the PodOpsLifecycle process?

@shaofan-hs
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@shaofan-hs shaofan-hs force-pushed the podopslifecycle branch 2 times, most recently from e1a50a3 to 4df1d02 Compare August 8, 2023 06:47
@wu8685
Copy link
Collaborator

wu8685 commented Aug 8, 2023

lgtm

@wu8685 wu8685 requested review from Eikykun and removed request for Eikykun August 8, 2023 15:26
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit ee2487e into main Aug 8, 2023
5 checks passed
@wu8685 wu8685 deleted the podopslifecycle branch August 8, 2023 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants