Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support label the pods that need to be deleted before the preparing phase #161

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Mar 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references:

2. What is the scope of this PR (e.g. component or file name):

collaset controller

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 63.98%. Comparing base (5eae342) to head (f136900).

Files Patch % Lines
pkg/controllers/utils/podopslifecycle/delete.go 0.00% 11 Missing ⚠️
pkg/controllers/utils/podopslifecycle/utils.go 73.33% 3 Missing and 1 partial ⚠️
...kg/controllers/collaset/utils/lifecycle_adapter.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   64.12%   63.98%   -0.14%     
==========================================
  Files          72       73       +1     
  Lines        4736     4754      +18     
==========================================
+ Hits         3037     3042       +5     
- Misses       1417     1430      +13     
  Partials      282      282              
Flag Coverage Δ
unittests 63.98% <44.82%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikykun Eikykun changed the title [WIP] support label the pods that need to be deleted before the preparing p… Support label the pods that need to be deleted before the preparing phase Mar 5, 2024
@Eikykun Eikykun force-pushed the 240222-recreate-label branch 3 times, most recently from 61fa327 to ee1a0b8 Compare March 11, 2024 08:24
@Eikykun Eikykun merged commit 0cdef01 into KusionStack:main Mar 11, 2024
5 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: support label the pods that need to be deleted before the preparing phase
3 participants