Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PodDecoration spec.injectStrategy.group #165

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Mar 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references:

2. What is the scope of this PR (e.g. component or file name):

PodDecoration

@Eikykun Eikykun added the kind/enhancement New feature or request label Mar 12, 2024
@Eikykun Eikykun self-assigned this Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.99%. Comparing base (0cdef01) to head (0a26f36).

Files Patch % Lines
pkg/controllers/utils/poddecoration/sort.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   63.92%   63.99%   +0.07%     
==========================================
  Files          73       73              
  Lines        4754     4711      -43     
==========================================
- Hits         3039     3015      -24     
+ Misses       1433     1421      -12     
+ Partials      282      275       -7     
Flag Coverage Δ
unittests 63.99% <87.50%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikykun Eikykun requested review from zoumo and wu8685 March 12, 2024 03:09
@Eikykun Eikykun linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 8087ea2 into KusionStack:main Mar 12, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Deprecate PodDecoration spec.injectStrategy.group
2 participants