Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rolling update by partition in PodDecoration #168

Merged
merged 5 commits into from
May 9, 2024

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Mar 19, 2024

1. Does this PR affect any open issues? and add issue references:

2. What is the scope of this PR (e.g. component or file name):

collaset controller
poddecoration controller

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Eikykun Eikykun force-pushed the 240319-partition branch 2 times, most recently from 1a28992 to cfe2794 Compare March 26, 2024 08:59
@Eikykun Eikykun requested a review from wu8685 March 26, 2024 09:10
@Eikykun Eikykun changed the title [WIP] Enhancement: Support PodDecoration rolling update by partition Enhancement: Support PodDecoration rolling update by partition Mar 26, 2024
@Eikykun Eikykun requested a review from zoumo March 26, 2024 09:10
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 67.61364% with 171 lines in your changes are missing coverage. Please review.

Project coverage is 66.10%. Comparing base (4544135) to head (a367b89).
Report is 14 commits behind head on main.

❗ Current head a367b89 differs from pull request most recent head c942b57. Consider uploading reports for the commit c942b57 to get more accurate results

Files Patch % Lines
...ontrollers/utils/poddecoration/strategy/manager.go 66.87% 78 Missing and 28 partials ⚠️
pkg/controllers/utils/poddecoration/getter.go 74.69% 15 Missing and 6 partials ⚠️
...trollers/poddecoration/poddecoration_controller.go 75.00% 6 Missing and 4 partials ⚠️
pkg/controllers/utils/poddecoration/anno.go 23.07% 9 Missing and 1 partial ⚠️
pkg/controllers/utils/poddecoration/sort.go 0.00% 4 Missing and 2 partials ⚠️
.../controllers/utils/poddecoration/strategy/utils.go 73.91% 4 Missing and 2 partials ⚠️
pkg/controllers/utils/selector.go 0.00% 6 Missing ⚠️
pkg/controllers/collaset/collaset_controller.go 66.66% 2 Missing and 1 partial ⚠️
pkg/controllers/utils/poddecoration/patch.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   65.11%   66.10%   +0.99%     
==========================================
  Files          74       75       +1     
  Lines        4810     5128     +318     
==========================================
+ Hits         3132     3390     +258     
- Misses       1397     1426      +29     
- Partials      281      312      +31     
Flag Coverage Δ
unittests 66.10% <67.61%> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikykun Eikykun requested a review from shaofan-hs March 26, 2024 13:01
@zoumo zoumo changed the title Enhancement: Support PodDecoration rolling update by partition feat: support rolling update by partition in PodDecoration Apr 24, 2024
Copy link
Collaborator

@zoumo zoumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@Eikykun Eikykun merged commit ebea328 into KusionStack:main May 9, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants