-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init ruleset #17
Merged
Merged
Init ruleset #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d2eebc
to
5606633
Compare
52ec064
to
5b9695e
Compare
a6edc49
to
dbc1628
Compare
wu8685
reviewed
Aug 8, 2023
7d3f90b
to
95e546d
Compare
shaofan-hs
reviewed
Aug 9, 2023
shaofan-hs
reviewed
Aug 11, 2023
shaofan-hs
reviewed
Aug 14, 2023
shaofan-hs
reviewed
Aug 14, 2023
shaofan-hs
reviewed
Aug 14, 2023
103777f
to
abd01ae
Compare
abd01ae
to
41bae49
Compare
shaofan-hs
reviewed
Aug 16, 2023
2fa09d5
to
3042d53
Compare
wu8685
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
} | ||
|
||
if err := r.updateRuleSetOnPod(ruleSet.Name, | ||
&corev1.Pod{ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: ruleSet.Namespace}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just pass Pod name
is enough?
shaofan-hs
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re Enhancement: RuleSet feature in v0.1.0 #10
2. What is the scope of this PR (e.g. component or file name):
contorller/ruleset
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.