fix(gracedelete webhook): limit the PodDeletionIndicationLabel update… #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… frequency to avoid update conflict
wu8685
reviewed
Apr 28, 2024
| @@ -37,6 +37,10 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/client" | |||
| ) | |||
|
|
|||
| var ( | |||
| updatePodDeletionIndicationLabelInterval = 5 * 1000 * 1000 * 1000 | |||
…rval to updateGraceDeleteTimestampAnnoInterval
wu8685
reviewed
Apr 30, 2024
| // limit the AnnotationGraceDeleteTimestamp update frequency to updateGraceDeleteTimestampAnnoInterval, | ||
| // to avoid update conflict caused by workload delete pod constantly | ||
| if timestamp, ok := newPod.Annotations[appsv1alpha1.AnnotationGraceDeleteTimestamp]; ok { | ||
| unixNano, err := strconv.ParseInt(timestamp, 10, 64) |
There was a problem hiding this comment.
unixNano => lastDeleteTimestamp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… frequency to avoid update conflict
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
pkg/webhook/server/generic/pod/gracedelete/webhook.go
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Fix GraceDelete#Validating method bug. Limit the PodDeletionIndicationLabel update frequency to 10s(default), to avoid update conflict when workload update or scale down, delete pod constantly.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note