Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale strategy pod to delete #199

Merged
merged 15 commits into from
May 10, 2024
Merged

Scale strategy pod to delete #199

merged 15 commits into from
May 10, 2024

Conversation

ColdsteelRail
Copy link
Collaborator

@ColdsteelRail ColdsteelRail commented Apr 28, 2024 •
edited

1. Does this PR affect any open issues?(Y/N) and add issue references :

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Eikykun
Eikykun reviewed Apr 28, 2024
View reviewed changes
Copy link
Member

@Eikykun Eikykun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/PTAL, @ColdsteelRail

pkg/controllers/collaset/synccontrol/scale.go Outdated Show resolved Hide resolved
pkg/webhook/server/generic/collaset/collaset_mutating_handler.go Outdated Show resolved Hide resolved
pkg/controllers/collaset/synccontrol/sync_control.go Outdated Show resolved Hide resolved
@ColdsteelRail ColdsteelRail force-pushed the scale-strategy-pod-to-delete branch 2 times, most recently from 585a767 to 848891d Compare April 29, 2024 05:06
@Eikykun
Copy link
Member

Eikykun commented Apr 29, 2024 •
edited

/lgtm, cc @wu8685

Eikykun
Eikykun approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@Eikykun Eikykun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ColdsteelRail ColdsteelRail removed the request for review from wu8685 May 10, 2024 02:21
@ColdsteelRail ColdsteelRail merged commit 7f1e94d into KusionStack:main May 10, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
@ColdsteelRail ColdsteelRail deleted the scale-strategy-pod-to-delete branch July 8, 2024 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Eikykun Eikykun Eikykun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FeatureRequest: CollaSet scaleStrategy supports PodToDelete
2 participants
@ColdsteelRail @Eikykun