feat: ResourceConsist Controller #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
WeichengWang1
requested review from
wu8685,
Eikykun,
shaofan-hs and
zoumo
and removed request for
wu8685
|
a demo controller implement resourceconsist updated. |
shaofan-hs
reviewed
Aug 16, 2023
pkg/controllers/demoresourceconsist/demoresourceconsist_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/demoresourceconsist/demoresourceconsist_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/demoresourceconsist/demoresourceconsist_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/demoresourceconsist/demoresourceconsist_controller.go
Outdated
Show resolved
Hide resolved
wu8685
reviewed
Aug 17, 2023
wu8685
reviewed
Aug 17, 2023
How about we move the demo codes under |
good idea |
wu8685
reviewed
Aug 25, 2023
pkg/controllers/alibaba_cloud_slb/alibaba_cloud_slb_controller.go
Outdated
Show resolved
Hide resolved
|
@wu8685 two review comments remained for further discussion, ptal. |
shaofan-hs
reviewed
Aug 28, 2023
pkg/controllers/alibaba_cloud_slb/alibaba_cloud_slb_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/alibaba_cloud_slb/alibaba_cloud_slb_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/alibaba_cloud_slb/alibaba_cloud_slb_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/alibaba_cloud_slb/alibaba_cloud_slb_controller.go
Outdated
Show resolved
Hide resolved
pkg/webhook/server/generic/pod/resourceconsist/webhookAdapters/adapters.go
Show resolved
Hide resolved
pkg/webhook/server/generic/pod/resourceconsist/webhookAdapters/adapters.go
Outdated
Show resolved
Hide resolved
shaofan-hs
approved these changes
Aug 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re Enhancement: ResourceConsist features #12
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
The PR offers a frame making a customized controller can be realized easily, and offering the ability of controllers following PodOpsLifecycle.
The only thing users need to do to realize a customized controller is writing an adapter implementing ReconcileAdapter.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
demo controller(pkg/controllers/demoresourceconsist) used as Test Cases.
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.