-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ResourceConsist Controller #24
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
a demo controller implement resourceconsist updated. |
pkg/controllers/demoresourceconsist/demoresourceconsist_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/demoresourceconsist/demoresourceconsist_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/demoresourceconsist/demoresourceconsist_controller.go
Outdated
Show resolved
Hide resolved
pkg/controllers/demoresourceconsist/demoresourceconsist_controller.go
Outdated
Show resolved
Hide resolved
How about we move the demo codes under |
good idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
pkg/controllers/alibaba_cloud_slb/alibaba_cloud_slb_controller.go
Outdated
Show resolved
Hide resolved
@wu8685 two review comments remained for further discussion, ptal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re Enhancement: ResourceConsist features #12
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
The PR offers a frame making a customized controller can be realized easily, and offering the ability of controllers following PodOpsLifecycle.
The only thing users need to do to realize a customized controller is writing an adapter implementing ReconcileAdapter.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
demo controller(pkg/controllers/demoresourceconsist) used as Test Cases.
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.