Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy controllers and webhooks using kind #32

Merged
merged 1 commit into from
Aug 17, 2023
Merged

deploy controllers and webhooks using kind #32

merged 1 commit into from
Aug 17, 2023

Conversation

shaofan-hs
Copy link
Collaborator

@shaofan-hs shaofan-hs commented Aug 17, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #30

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@shaofan-hs shaofan-hs force-pushed the kind-deploy branch 4 times, most recently from 1b278b5 to d6dc3c0 Compare August 17, 2023 09:57
@shaofan-hs shaofan-hs force-pushed the kind-deploy branch 3 times, most recently from cc6c01e to 5b59e3d Compare August 17, 2023 11:08
Copy link
Member

@Eikykun Eikykun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shaofan-hs shaofan-hs merged commit e53e3af into main Aug 17, 2023
5 checks passed
@shaofan-hs shaofan-hs deleted the kind-deploy branch August 17, 2023 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants